Fix Firo masternode registration to use external collateral instead of redundantly re-sending 1000 FIRO#1284
Draft
navidR wants to merge 1 commit intocypherstack:stagingfrom
Draft
Conversation
…f redundantly re-sending 1000 FIRO
sneurlax
requested changes
Mar 23, 2026
Comment on lines
+565
to
+566
| navigator.pushNamed( | ||
| CreateMasternodeView.routeName, |
Member
There was a problem hiding this comment.
these lines break desktop: CreateMasternodeView is designed to be shown as a dialog
check like how masternodes_home_view.dart works:
if (Util.isDesktop) {
final txid = await showDialog<Object>(
context: context,
barrierDismissible: true,
builder: (context) => SDialog(
child: CreateMasternodeView(
...
),
),
);
_handleSuccessTxid(txid);
} else {
final txid = await Navigator.of(context).pushNamed(
CreateMasternodeView.routeName,
...
}
sneurlax
reviewed
Mar 23, 2026
| unawaited(wallet.refresh()); | ||
| if (wallet is FiroWallet) { | ||
| try { | ||
| await wallet.refresh(); |
Member
There was a problem hiding this comment.
this locks the ui until done. might be acceptable if the ui doesn't otherwise update correctly but preferably the ui should refresh async somehow. not sure how that has to work tho
sneurlax
requested changes
Mar 23, 2026
| child: Text( | ||
| "Create masternode", | ||
| style: STextStyles.desktopH3(context), | ||
| builder: (child) => Material( |
Member
There was a problem hiding this comment.
this Material wrapper is needed when navigating like this, but once you're navigating the right way, this becomes a double wrapper w/ double padding and this Material() can go away
Member
Member
|
as in #1288 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.